search

wesdu / fastapi-opentracing

fastapi opentracing middleware works on k8s
MIT License
23 stars 7 forks source link

Trying to get unit tests to run so I can contribute #20

Open n1ckdm opened 2 years ago

n1ckdm commented 2 years ago

Having some issues getting the unit tests to run. I followed the README and did a make bootstrap followed by a make test but I'm getting a bunch of errors about not having redis installed. I installed the additional dependencies in the /tests/requirements.txt file as well.

I'm guessing there are a bunch of other pre-requisites to contribute? I think if there are external services like Redis, these should either be mocked (for unit testing) or part of a some separate integration tests that use docker so they are platform independent. That will make it easier to get up and running and allow others to develop.

I'd be happy to put some time into this if it would be a welcome PR?

In terms of contriution, all I'm really trying to do at the moment is bump up Fast API and uvicorn to the latest versions.

mizhexiaoxiao commented 2 years ago

Sorry for the late reply, the unit problem has been fixed, see details cc69734229f94995b5f2b4b5a5582e12e7a54ba7.Now you can run make bootstrap to install all dependencies before developing or contributing.

If you can improve anything in this repo, feel free to add a pull request or a comment below.