search

weserv / images

Source code of wsrv.nl (formerly images.weserv.nl), to be used on your own server(s).
https://wsrv.nl/
BSD 3-Clause "New" or "Revised" License
1.84k stars 187 forks source link

Multi-platform images for docker #362

Closed RobinGiel closed 1 year ago

RobinGiel commented 1 year ago

Currently only amd64 is supported. I'm currenlty using linux/arm64/v8 I'm getting issues with the official github image. Is there any way to make this multi platform?

kleisauke commented 1 year ago

Both Docker files (Dockerfile and alpine.Dockerfile) should already be supported on AArch64, see: #327.

We could provide a pre-built Docker image for this architecture once GitHub Actions supports this architecture natively. I do not plan to cross-compile or build this under virtualization (e.g. via QEMU, Buildx, or similar), as that will significantly affect the build time in CI.

RobinGiel commented 1 year ago

Both Docker files (Dockerfile and alpine.Dockerfile) should already be supported on AArch64, see: #327.

We could provide a pre-built Docker image for this architecture once GitHub Actions supports this architecture natively. I do not plan to cross-compile or build this under virtualization (e.g. via QEMU, Buildx, or similar), as that will significantly affect the build time in CI.

Both Docker files (Dockerfile and alpine.Dockerfile) should already be supported on AArch64, see: #327.

We could provide a pre-built Docker image for this architecture once GitHub Actions supports this architecture natively. I do not plan to cross-compile or build this under virtualization (e.g. via QEMU, Buildx, or similar), as that will significantly affect the build time in CI.

https://amperecomputing.com/blogs/adding-aarch64-to-your-github-ci-with-github-actions-and-ampere-altra.html

According to this article, Github actions already supports it

kleisauke commented 1 year ago

It's supported, but that requires a self-hosted runner, hence the mention of "natively".

We do not currently have the necessary hardware available to host an ARM64-based GitHub Actions runner, other than the various Raspberry Pi's I own (which are already being used for testing purposes).

RobinGiel commented 1 year ago

It's supported, but that requires a self-hosted runner, hence the mention of "natively".

We do not currently have the necessary hardware available to host an ARM64-based GitHub Actions runner, other than the various Raspberry Pi's I own (which are already being used for testing purposes).

Not to promote Oracle, but there is currently a always forever free tier option to have your own image running ubuntu on ARM. In case you need to test some more. Thanks again for your feedback and the product :-)

kleisauke commented 1 year ago

I'll close, will revisit this once AArch64 is natively supported by GitHub Actions.