search

weshatheleopard / rubyXL

Ruby lib for reading/writing/modifying .xlsx and .xlsm files
MIT License
1.28k stars 255 forks source link

2016315 create numbers compatible xlsx #232

Closed shane2008 closed 8 years ago

shane2008 commented 8 years ago

Not to include shared string as related objects when there is no shared strings. This resolves the same issue described in https://github.com/weshatheleopard/rubyXL/issues/158 (Numbers in iOS can't open rubyXL generated xlsx file)

weshatheleopard commented 8 years ago

See https://github.com/weshatheleopard/rubyXL/commit/82573bfe2d36ba04f76b958eab96c3b5404ee8e9

Note that related_objects stores the objects that are related to the specific object, which means it shouldn't be treated as mutable, whereas collect_related_objects collects them immediately prior to file save, and therefore is the right place for that logic.

shane2008 commented 8 years ago

Thanks for making this change!