weshatheleopard / rubyXL

Ruby lib for reading/writing/modifying .xlsx and .xlsm files
MIT License
1.28k stars 255 forks source link

Add safe navigation operator #318

Closed angeqyang closed 5 years ago

angeqyang commented 5 years ago

This pull request addresses https://github.com/weshatheleopard/rubyXL/issues/317, where nil.dup results in an error. It is addressed by using :& in case there is no existing alignment.

This bug was introduced in this commit which was meant to resolve this issue https://github.com/weshatheleopard/rubyXL/issues/315

angeqyang commented 5 years ago

Hi @weshatheleopard I have a fix up for this issue, would it be possible to review this? I think a recent change caused a blocking issue

bjohns2 commented 5 years ago

@weshatheleopard this is causing an error for me as well

weshatheleopard commented 5 years ago

This should be fixed in 3.4.0