search

weshatheleopard / rubyXL

Ruby lib for reading/writing/modifying .xlsx and .xlsm files
MIT License
1.27k stars 253 forks source link

Update ruby version requirement on rubygems.org #326

Closed evanthegrayt closed 5 years ago

evanthegrayt commented 5 years ago

According to rubygems.org:

image

But the changes since RubyXL 3.4.0 broke compatibility with Ruby < 2.1. The new convenience method modules use the following:

RubyXL::Cell.include(RubyXL::CellConvenienceMethods)

But Module#include is a private method before 2.1. The gem could be updated to use:

RubyXL::Cell.send(:include, RubyXL::CellConvenienceMethods)

...or the info on https://rubygems.org/gems/rubyXL should be updated.

I know most people won't be using a ruby that's this old, but we're stuck with an old version where I work, so this info would be appreciated.

weshatheleopard commented 5 years ago

Thank you for the info. I'll try to keep this gem functioning on older versions as long as possible, however I can't test every single one myself, so your input is appreciated. 3.4.2 should be compatible with <2.1 again.

evanthegrayt commented 5 years ago

Thank you so much!