search

weshatheleopard / rubyXL

Ruby lib for reading/writing/modifying .xlsx and .xlsm files
MIT License
1.27k stars 253 forks source link

RubyZip 3.0 will introduce breaking changes that rubyXL will currently depend upon #430

Closed jakevose closed 1 year ago

jakevose commented 1 year ago

Good afternoon, while running bundle this morning we noticed that RubyZip is getting a major version bump:

Post-install message from rubyzip:
RubyZip 3.0 is coming!
**********************

The public API of some Rubyzip classes has been modernized to use named
parameters for optional arguments. Please check your usage of the
following classes:
  * `Zip::File`
  * `Zip::Entry`
  * `Zip::InputStream`
  * `Zip::OutputStream`

Please ensure that your Gemfiles and .gemspecs are suitably restrictive
to avoid an unexpected breakage when 3.0 is released (e.g. ~> 2.3.0).
See https://github.com/rubyzip/rubyzip for details. The Changelog also
lists other enhancements and bugfixes that have been implemented since
version 2.3.0.

It appears that rubyXL will pull in the breaking changes automatically by gemspec:

    rubyXL (3.4.25)
      nokogiri (>= 1.10.8)
      rubyzip (>= 1.3.0)

Can you please review and adjust as needed?

weshatheleopard commented 1 year ago

I reviewed the code and I do not believe that RubyXL is using Zip in a manner that would make it affected.