search

wesleyburr / subMaldi

subMaldi: a package for R
GNU General Public License v3.0
3 stars 3 forks source link

JOSS 10 #15

Closed wesleyburr closed 3 years ago

wesleyburr commented 3 years ago

The code is easily readable and easy to browse, nonetheless the test code base does not share the same quality standard, please consider looking into this. An automated code formatting tool could help in this regard (for instance: https://github.com/r-lib/styler).

Let's do this while expanding test coverage.

wesleyburr commented 3 years ago

The code has been adapted tremendously: we took this opportunity to do a full refactor.

wesleyburr commented 3 years ago

Done cleaning up the tests - Sophie rewrote them all using testthat and expanded the coverage, and then we ran them through styler.