search

wesleytodd / YeoPress

A Yeoman generator for WordPress
Other
1.08k stars 163 forks source link

Installing as a submodule #102

Closed victormoukhortov closed 10 years ago

victormoukhortov commented 10 years ago

YeoPress does not seem to install Wordpress as a submodule correctly:

Would you like to install WordPress as a submodule? Yes
WordPress install directory: wp

...

Installing WordPress 3.9 as a submodule
Submodule added
Checking out WP version 3.9
WordPress installed

...

cd wp
git status
HEAD detached at 3.9
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)

modified:   index.php
modified:   license.txt
    #All Wordpress core files redacted for brevety
modified:   xmlrpc.php

All of Wordpress core is marked as modified inside the submodule. This is certainly not the case when a submodule is checked-out properly. It seems that simple-git is being used for this functionality. Perhaps the problem lies there?

wesleytodd commented 10 years ago

My guess is permissions. Try running git config core.fileMode false in the submodule.

I have a comment in the section where it sets permissions about removing it, because it can cause weird things like this. But at the time I don't think it worked without setting the permissions...

wesleytodd commented 10 years ago

Are you still having this issue? If not I am going to close this.

victormoukhortov commented 10 years ago

It seems to be working most of the time.

On Fri, Jun 6, 2014 at 10:06 AM, Wes Todd notifications@github.com wrote:

Are you still having this issue? If not I am going to close this.

— Reply to this email directly or view it on GitHub https://github.com/wesleytodd/YeoPress/issues/102#issuecomment-45293283.