search

wesleytodd / YeoPress

A Yeoman generator for WordPress
Other
1.08k stars 163 forks source link

fixes issue with a null conflict while installing wordpress #133

Closed Toddses closed 9 years ago

Toddses commented 9 years ago

I believe this should fix issue #132.

For some reason bulkDirectory() wanted to run a conflict check with null and always found a conflict. Doing some research the Yeoman API doc says to not use bulkDirectory() unless there's no other solution. directory() does the same conflict resolution but doesn't generate a null check, so I think that takes care of the automatic conflict issue.

wesleytodd commented 9 years ago

That bulkDirectory call is because WP has so many files that it causes a max call stack error when trying to process them all. Unless they have fixed that problem this is required. I am actually the one who wrote that method in yeoman. Unfortunately the underlying conflict checking stuff didn't have an issue until later.

Toddses commented 9 years ago

OK I wondered about the choice of bulkDirectory. Using directory did not fire a max call stack error for me, so maybe that has been resolved. I'll try and look into it.

wesleytodd commented 9 years ago

It was intermittent, but I used to be able to repro it pretty regularly.

Toddses commented 9 years ago

Well, based on yeoman/generator#658 sounds like for 0.18.0, part of the file system rewrite was to negate the need for bulkCopy when installing things like WordPress. I'll try and get YeoPress up to that version of the generator and see how things go. Everything should be backwards compatible, but obviously converting to the new file system is a major update.

wesleytodd commented 9 years ago

Awesome, thanks @Toddses!!! I have not been using WP much since I left the agency world for a startup, so I have not been doing much feature development on this. If you are using it and have success with the codebase I would be happy to pull you in to the project. Let me know if you are interested.

Toddses commented 9 years ago

That sounds good! I shot you an email.

wesleytodd commented 9 years ago

Close this in favor of #134?

Toddses commented 9 years ago

indeed.