search

wesleytodd / YeoPress

A Yeoman generator for WordPress
Other
1.08k stars 163 forks source link

refactors for yeoman-generator 0.18.7 #134

Closed Toddses closed 9 years ago

Toddses commented 9 years ago

Okay here is the refactor. I bumped the version to 2.0.0 because it'll be a major update. There's a few smaller bug fixes in here too.

The new filesystem works a bit different so it required some tweaking of the order of functions and such. But as of this PR the user experience is pretty much the same as the current master branch. I'd like to get the remaining packages up to their latest versions as well, but I think this PR is ready for human consumption. I'd like to get it verified that we won't see the max call stack error. I have not been able to reproduce it at all with this version.

wesleytodd commented 9 years ago

I especially like your continuation of the random function names :+1:

wesleytodd commented 9 years ago

Once you get those changes made I will pull it down and go through it a few times to make sure I don't get any issues, but other than that it all looks great! Thanks for the hard work!

Toddses commented 9 years ago

OK I've made the changes.

For the setupTheme change to a callback instead of this.async, I rolled back, and am going to open a new issue related to that.

wesleytodd commented 9 years ago

Ok, merged this with only a few changes. I am guessing you didn't test the vagrant stuff, but I fixed the issues there. Also, there was a small issue where the theme files were not committed before trying to run the build steps. It was just a missing call to this.async, so I fixed that as well. While I was at it I also updated some things like using bind instead of var me = this.

So, If you could pull down develop and do a last round of testing after my changes that would be awesome. If it fully works for you then I will release 2.0!!

Toddses commented 9 years ago

OK I ran through it a bunch of times with no issues. Looks like its good to go!

wesleytodd commented 9 years ago

Same here, I merged your other one as well, so we should be good to go. Ill merge it up to master and release later tonight.