search

wesleytodd / YeoPress

A Yeoman generator for WordPress
Other
1.08k stars 163 forks source link

#_ is deprecated #152

Open Toddses opened 9 years ago

Toddses commented 9 years ago

Get this warning when running YeoPress with the latest version of yeoman-generator (0.19.1)

(!) #_ is deprecated. Require your own version of Lodash or underscore.string
wesleytodd commented 9 years ago

https://github.com/yeoman/generator/issues/766

Looks like our new release will need this fix as well.

wesleytodd commented 9 years ago

This is actually a much bigger problem than I thought. The fs refactor is causing internal wordpress files to be parsed as templates, specifically this one: https://core.trac.wordpress.org/browser/tags/4.1.1/src/wp-includes/class-wp-customize-widgets.php#L708

So this is actually mangling wp functionality.

I dont have time to work on this right now, but if you want to, all we need to do is make that one call NOT do template parsing.

wesleytodd commented 9 years ago

and fwiw, i pushed an error log and a beta tag in package.json so if we get this fixed we can publish a beta with the fixes.

Vivekbhusal commented 9 years ago

is there any update on for this issue? i am trying to generate wordpress-plugin using wp-make. Is there any work around or patches?

Toddses commented 9 years ago

Not really atm. Time has been an issue for me lately, as I'm sure for Wes as well. If someone can issue a valid pull request I am sure we will pull it in.

That said I have still been using YeoPress with this deprecation warning and have had no issues myself.

wesleytodd commented 9 years ago

^^ what he said :)

Also I am not sure where wp-make comes in here, are you trying to switch to yeopress? If so this issue shouldn't actually break anything, we just need to fix it before it is actually removed from yeoman.