search

wesleytodd / YeoPress

A Yeoman generator for WordPress
Other
1.08k stars 161 forks source link

Got directory of undefined type error when project name contains underscore #157

Closed theoptips closed 9 years ago

theoptips commented 9 years ago

Got this error and try to yeopress into a project/app directory who name contains underscores example: test_wordpress

        remote.directory('.', this.conf.get('wpDir'));
              ^

TypeError: Cannot read property 'directory' of undefined

Toddses commented 9 years ago

Just for reference, can you check your yeopress version?

Sounds a lot like #147 #149 #150, though this would be the first time with the underscore thing.

alextegelid commented 9 years ago

I'm seeing the same error, however my directory contains only lowercase letters (using the directory name wordpress for debug purposes). I've made multiple tries, cleaning the ~/.cache/yeoman before each try.

Toddses commented 9 years ago

Pop open YeoPress's package.json, and change the version of yeoman-generator to 0.19.2, and reinstall yeoman-generator. Let us know if that does the trick @alextegelid @theoptips

wesleytodd commented 9 years ago

@Toddses Maybe i should release that version despite the other problems? I haven't had time to deal with them. What do you think?

Toddses commented 9 years ago

@wesleytodd Yeah I think so, too. It would probably be better to have a working version out there, even with a deprecation warning, than a non-working version.

wesleytodd commented 9 years ago

Ok, published.

alextegelid commented 9 years ago

@wesleytodd This update works fine on my machine. Thanks!

wesleytodd commented 9 years ago

@alextegelid Awesome!! Sorry for the issues, wordpress's repo had some weird conflict with the unzip library that Yeoman used. And then we had some other weird issue with template strings inside some wordpress core files. Anyway, it was a pain of a release and so was sitting there for a bit :(

wesleytodd commented 9 years ago

@theoptips Re-open this if it did not fix the issue for you. Thanks!!