search

wesleytodd / YeoPress

A Yeoman generator for WordPress
Other
1.08k stars 163 forks source link

Use Git? set to false in .yeopress, but prompt still set to Yes #172

Open nocean opened 8 years ago

nocean commented 8 years ago

I'm setting "git": false in a custom .yeopress file, but the default for the "Use Git?" prompt remains "Yes" (Y/n).

Glancing through app/prompts.js, it does appear to be set to a default of "no", which matches the readme documentation talking about overriding this. However, even without a custom .yeopress file, when running yo wordpress it defaults to yes.

BTW: I love this project. Thanks so much for it.

wesleytodd commented 8 years ago

So I am not sure, but it does look like the 'N' default value would evaluate to true. Do you think you can try swapping that for false in here and see if you get the desired effect?

If so I would love a PR or I can make the change and publish really quick.

wesleytodd commented 8 years ago

FWIW, this used to work, but reading the inquirer documentation it says a boolean value. So maybe it changed??? I guess that is what software does...

nocean commented 8 years ago

Just tested, and changing to false works as expected -- also tested overriding with a .yeopress file, and it also works as expected. Just submitted the PR. Let me know if I did anything wrong, first time I've ever submitted a change on GitHub.

wesleytodd commented 8 years ago

Hey, so it looks like you pushed your work but didnt open the PR. On your repo page you will have a button to open a PR. Make sure you submit it against the develop branch as it talks about in the contributor docs: https://github.com/wesleytodd/YeoPress/blob/master/CONTRIBUTING.md

I looked at the change and it looks good! Thanks for finding and fixing this!

nocean commented 8 years ago

Oops. Just did. (fingers crossed)