search

wesleytodd / YeoPress

A Yeoman generator for WordPress
Other
1.08k stars 163 forks source link

'grunt setup' task error #185

Open TFOH opened 7 years ago

TFOH commented 7 years ago

I attempted to run the grunt setup task inside the yeopress theme folder but an error was returned:

$ grunt setup

Running "setup" task

Running "sass:dev" (sass) task

Running "bower-install" task bower cloning https://github.com/jquery/jquery-dist.git bower cloning https://github.com/jrburke/requirejs-bower.git { [Error: status code of git: 128] details: 'fatal: Not a git repository (or any of the parent directories): .git\n', command: 'git', code: 128 } { [Error: status code of git: 128] details: '', command: 'git', code: 128 }

Done, without errors.

After looking at the URL https://github.com/jrburke/requirejs-bower i was redirected to https://github.com/requirejs/requirejs-bower instead. Is this why I got an error on running the task?

I thought it might still work so I continued to then run:

$ grunt bower Running "bower:all" (bower) task

Which looked fine so then I ran:

grunt requirejs Running "requirejs:production" (requirejs) task >> Error: ENOENT: no such file or directory, open >> '/Users/timdarker/Documents/Sites/htdocs/yeopress-test2/content/themes/yeopre >> ss/js/vendor/jquery/jquery.js' >> In module tree: >> global Warning: RequireJS failed. Use --force to continue.

Aborted due to warnings.

I noticed the folder 'js/vendor' has not been created. How do I fix this? Thanks in advance.

wesleytodd commented 7 years ago

TBQH, I haven't used wordpress, grunt, require or bower in years lol. If someone wants to make a new template repository which follows current best practices then I would happily convert this generator to point to a new default. But I am not in a place where I have the time or drive to update this myself.

That all being said, yes I think your assessment of the situation is correct, the change of url broke it. If you want to PR it here I will merge it, but I think making a new template default is a better long term solution.

TFOH commented 7 years ago

Hi Wes thanks for the reply. Completely understandable, I'm sure you're a busy man.

Just to satisfy my OCD seen as I got this far lol, I had a good look but was unable to find where the broken URL was referenced, can you point me in the right direction of where to update the requirejs git URL?

Out of interest what in your opinion would you consider the current best practices for a new default template? I may well take the time to do that.

brmullikin commented 7 years ago

@TFOH

https://github.com/roots/sage is pretty good.

So is https://github.com/timber/timber and the various themes built off of it.

wesleytodd commented 7 years ago

If either of you, @brmullikin or @TFOH, want to get this generator setup to pull in one of those I would be eternally grateful. I really have wanted to trash the old default template, because I feel like it leads people down a bad path. And this generator really doesn't care WHAT template is imported, it just needs a default.

@TFOH As for debugging this issue, I am sorry I couldn't even point you in the right direction anymore.