wesleytodd / YeoPress

A Yeoman generator for WordPress
Other
1.08k stars 161 forks source link

Use of WP_HTTP_BLOCK_EXTERNAL in config with submoduled git #32

Closed jegtnes closed 11 years ago

jegtnes commented 11 years ago

Hey Wes,

I was trying to install some plugins earlier on a WP YeoPress install where I opted to use Git as a submodule and ran into the fabled "An unexpected error occured" error message when trying to add a plugin. I thought this was a newfound problem with my server setup or perhaps some file permissions gone awry, but it turns out that's a result of WP_HTTP_BLOCK_EXTERNAL being set in wp-config; removing this solved my problem. I understand this will stop WordPress from nagging about updates (as all external requests are blocked, WP can't ever find any), but it also causes you to be unable to search for or install any plugins or themes straight from the dashboard.

In my opinion, this is a bit heavy-handed. Is there perhaps an easier or more obvious way of solving the 'don't show update' conundrum without blocking all external requests? Perhaps install a plugin doing this by default if using git as a submodule or just warn about this when doing the YeoPress installation?

wesleytodd commented 11 years ago

That probably should not have made it into that template. That was added while I was first developing this generator because the company I worked for didn't want clients installing un-approved plugins. I won't be able to get that tonight, but if you submit a pr for it I will merge and release it asap.

Also, if you feel like adding an advanced promot to optionally include it still that would be excellent!

wesleytodd commented 11 years ago

Also, I don't believe there is any other way to remove that message without adding styles to the admin. Which is also not in the purview of this generator, IMHO.

wesleytodd commented 11 years ago

Added the advanced option with the new prompts setup