wesleytodd / YeoPress

A Yeoman generator for WordPress
Other
1.08k stars 161 forks source link

bower.json #36

Closed g-kanoufi closed 10 years ago

g-kanoufi commented 11 years ago

Hi Wesley,

So i wanted to change inside the template 2 things, first changing package.json to bower.json(as advised on the bower website), problem is that will say at the end of the install that package.json is missing, i am pretty sure it's nothing to fix for you.

Second thing was to change the .bowerrc file to put all bower dependencies inside a bower_components folder so you can add various type of file ex: require.js but also inuit.css.

Please let me know what you think about that, i can make a pull request if you think that is interesting enough.

wesleytodd commented 11 years ago

So I am good with the addition of the bower.json. But do not remove the package.json. That file has the grunt dependancies and can be used in other ways that bower.json is not intended for.

For the bower_components thing, maybe we could get some prompts during the template setup process that allow for choosing these settings. I am working on a better implementation of the prompts. So once that is done I will look at getting prompts in place in the template install process.

I am willing to consider all changes, so feel free to fork and hack all you want in the template because all you have to do is specify your version in the YeoPress install process to use it. For anything that you want you upstream, please submit the PR's agains the template-develop branch and I will take a look.

wesleytodd commented 11 years ago

@g-kanoufi Any news on this? Otherwise I am going to close it.

g-kanoufi commented 10 years ago

Hi Wesley,

Sorry i had no time those last weeks, i’ll try to make this during this week, is that ok?

Guillaume Kanoufi

On 29 Oct 2013, at 22:36, Wes Todd notifications@github.com wrote:

@g-kanoufi Any news on this? Otherwise I am going to close it.

— Reply to this email directly or view it on GitHub.

wesleytodd commented 10 years ago

Sounds good @g-kanoufi

wesleytodd commented 10 years ago

Closed pending #63 being re-made against template-develop