search

wesleytodd / YeoPress

A Yeoman generator for WordPress
Other
1.08k stars 161 forks source link

Messy prompts on git bash #49

Closed jahvi closed 10 years ago

jahvi commented 11 years ago

I'm not sure if it's just me but the prompts look messy on the git bash running Win7 64bits, I recorded a small screencast of the issue.

The values get stored just fine though, it just looks like a display issue.

PD: I tested on my Arch 64bits install and I'm getting the same issue.

wesleytodd commented 11 years ago

That looks like a problem with the read module, which is what I use to display the prompts. Maybe you can install that module and write a test case to see if that is what is causing the problem or if it is my usage of it.

Here is that module: https://npmjs.org/package/read

I don't run windows, so I cannot help much. But I would be happy to merge any fixes you can find.

jahvi commented 11 years ago

Let me see if I can pinpoint the issue, that's for the tip. On Oct 23, 2013 4:16 PM, "Wes Todd" notifications@github.com wrote:

That looks like a problem with the read module, which is what I use to display the prompts. Maybe you can install that module and write a test case to see if that is what is causing the problem or if it is my usage of it.

Here is that module: https://npmjs.org/package/read

I don't run windows, so I cannot help much. But I would be happy to merge any fixes you can find.

— Reply to this email directly or view it on GitHubhttps://github.com/wesleytodd/YeoPress/issues/49#issuecomment-26944028 .

jahvi commented 11 years ago

BTW why are you using prompt-improved instead of inquirer? Is it because you're using an older version of yeoman-generator or does it have any other advantages?

wesleytodd commented 11 years ago

Two reasons:

  1. Because I was on the older version of the generator due to the bulk-copy issue.
  2. I needed other features. Conditional prompts for the prompt "forks" and overriding the defaults.

I had just finished the package and integrating it when I saw that Simon had written one or I would have just improved on his. I may consider moving over at some point, but since I only recently finished adding that I am not up for it just yet.

jahvi commented 11 years ago

That makes sense, I've had no luck trying to figure out the issue but I'll keep looking

cbebry commented 11 years ago

This same symptom happens to me when using PuTTY to access my Linux server from my Windows7 box.

wesleytodd commented 11 years ago

Do you guys have this problem with the new prompt system bundled with Yeoman? If not I will just get moving over to that higher up on the list of to-do's.

jahvi commented 11 years ago

Nope yeoman's work just fine on my end On Oct 29, 2013 5:05 PM, "Wes Todd" notifications@github.com wrote:

Do you guys have this problem with the new prompt systemhttps://npmjs.org/package/inquirerbundled with Yeoman? If not I will just get moving over to that higher up on the list of to-do's.

— Reply to this email directly or view it on GitHubhttps://github.com/wesleytodd/YeoPress/issues/49#issuecomment-27345656 .

cbebry commented 11 years ago

Other yeomans work OK for me if that is what you are asking. Unless you mean there is a different version of yeopress I should try out, but I used the one from npm.

wesleytodd commented 11 years ago

Ok, well then I will mark this for the to-do list. Thanks for the input.

wesleytodd commented 10 years ago

Converted to the built in prompts now that I am updated to the newest version of yeoman-generator