wesleytodd / YeoPress

A Yeoman generator for WordPress
Other
1.08k stars 161 forks source link

Arguments to path.join must be strings #51

Closed uknick closed 10 years ago

uknick commented 10 years ago

Running the generator I get:

note: already saw the closed issue but didn't seem to resolve it.

c:\wamp\www\wordpress>yo wordpress

path.js:204
        throw new TypeError('Arguments to path.join must be strings');
              ^
TypeError: Arguments to path.join must be strings
    at f (path.js:204:15)
    at Object.filter (native)
    at Object.exports.join (path.js:209:40)
    at new module.exports (C:\Users\Nick\AppData\Roaming\npm\node_modules\genera
tor-wordpress\util\config.js:25:31)
    at new Generator (C:\Users\Nick\AppData\Roaming\npm\node_modules\generator-w
ordpress\app\index.js:57:14)
    at Environment.create (C:\Users\Nick\AppData\Roaming\npm\node_modules\yo\nod
e_modules\yeoman-generator\lib\env.js:366:10)
    at Environment.run (C:\Users\Nick\AppData\Roaming\npm\node_modules\yo\node_m
odules\yeoman-generator\lib\env.js:409:24)
    at init (C:\Users\Nick\AppData\Roaming\npm\node_modules\yo\bin\yo:98:7)
    at pre (C:\Users\Nick\AppData\Roaming\npm\node_modules\yo\bin\yo:110:3)
    at Object.<anonymous> (C:\Users\Nick\AppData\Roaming\npm\node_modules\yo\bin
\yo:135:1)

Set up Windows 7 64bit Node version - v0.10.21

C:\Users\Nick>node
> process.env.HOME
undefined

I didn't have a path set for home, I know this could be added in the Environment variables, however...

for the fix

I seem to have got this working, in \util\config.js I changed:

    this.global = this.load(path.join(process.env.HOME, this.filename)) || {}; 

to

this.global = this.load(path.join(process.env.HOME || process.env.USERPROFILE, this.filename)) || {};

reading: https://github.com/fgnass/node-dev/pull/60 http://dailyjs.com/2012/05/24/windows-and-node-4/ (environment section)