Closed humantorch closed 10 years ago
This is a consequence of updating the generator but not the theme. The userInput
should be changed to conf
. If you have time and feel like submitting a PR for this I would happily merge it. If you do, please make the PR against the develop branch. Otherwise I might not be able to fix this until later this week.
I'd love to help out with this one Wesley, but it's got me scratching my head.
I tried to update the global.js file in the theme to have the correct code. I was thinking this would do it, but when I ran the generator this section wasn't updated.
"baseUrl": "<%= conf.get('contentDir') %>/themes/<%= conf.get('themeDir') %>/js"
If you give me a clue I'll get it sorted as this project has been a real time saver for me so far.
Cheers Rob.
Did you follow something like the steps in the contribution docs?
Any changes you make to the generator should be in your copy of the git repo. Then when you are ready and it is working, you can make a PR against the develop
branch. Let me know if that helps!
Hey Wes,
I was just confirming with you whether it's the template that should be updated or is it the generator itself?
I updated a template that I use myself with the above code and when I ran the generator on it it didn't update those values.
Once I know that I'll go through the proper contribution method with your template.
This is the file that should be updated: https://github.com/wesleytodd/YeoPress/blob/template/functions.php
Sorry, I guess I didn't understand your question. Does that help?
Ok great. Looks like global.js needs editing as well.
When I edited this file on my own version of the template the values were not replaced as expected though when I used the generator. The global.js file still had:
"baseUrl": "<%= conf.get('contentDir') %>/themes/<%= conf.get('themeDir') %>/js"
....rather than being replaced with what I had typed in the generator.
Any ideas?
Fixed in #77
Just installed and ran YeoPress for the first time today and came across the following issue: the value I entered for the WordPress content directory and URL are being entered into the .yeopress file but aren't being used in the various includes throughout the generated site. I'm still seeing code like:
wp_register_script('livereload', '<%= userInput.url %>:35729/livereload.js?snipver=1', null, false, true);
in my yeopress functions.php file and various CSS files, so styles are broken and livereload and jQuery aren't loading. I can go through and manually update them but it seems like either something is broken in my YeoPress install or (more likely) I'm Doing It Wrong™.
Ever seen that happen before? Let me know if I can provide any more information. There were no errors reported during the installation of the generator or when running it to instantiate a site.