Closed unr closed 10 years ago
That is only used if the list tags operation fails, so as a fallback. Was the operation failing for you?
I will merge this, but it would be helpful if you could investigate why it was falling back and post more information.
We were using YeoPress to set up a new project. Wanted to use Github, and do the nifty /content /wordpress directory set up.
No matter what we did, it always installed 3.5.1. We couldn't find any option to make it pull 'latest', or even a specific version. Was there perhaps a thing I missed?
https://github.com/unr/YeoPress/blob/663703f1da50b24daaf36a67d05d3b78616548aa/util/wordpress.js#L27
If you look at the code right there you can see that it lists the remote tags, which should be the versions of WP. If you throw some logs in there you might be able to shed some light.
Secondly, if you run with the advanced
flag you can manually specify the wordpress version it will use:
$ yo wordpress --advanced
Let me know if that helps! And sorry about the problems.
Could do with loading the latest version of Wordpress regardless. Or perhaps asking the user during install?
@tmoitie You can specify the version with the --advanced
flag. Were you also have g this problem?
There was actually a bug with the regex for pulling the version. Versions like 3.7.1 worked but the most recent version tag was 3.8, notice the lack of a patch number. I fixed this and also merged your PR. Hope this works for you now!
You're the best!
Ha! Thanks @unr!
Why is this hardcoded in the first place? #nothelping