search

wesleytodd / YeoPress

A Yeoman generator for WordPress
Other
1.08k stars 163 forks source link

refactor(util wordpress): minor refactor for variable declarations #89

Closed felixzapata closed 10 years ago

wesleytodd commented 10 years ago

Actually, it turns out this is not being used. I probably should have removed the code, but I wanted to get this feature published. And for the record, this is a valid way to assign both variables the value 0.

felixzapata commented 10 years ago

but, with this declaration, "requested" and "errors" are local and "complete" becomes global and I think that you want "complete" to be local.

wesleytodd commented 10 years ago

You are totally right @felixzapata. Luckily this code is actually not being run/used. So no worries, but thanks for the good point.