Allow use of OS X and Windows color picker without freezing Sublime Text

weslly / ColorPicker

Color picker for Sublime Text

http://weslly.github.io/ColorPicker

511 stars 108 forks source link

Allow use of OS X and Windows color picker without freezing Sublime Text #38

Closed BigEndian closed 10 years ago

BigEndian commented 10 years ago

This is a pretty hack-y approach, but it seems to work on OS X 10.9 (with Sublime Text 3) and Windows 7 with Sublime Text 2 and 3.

It may not work at all on Sublime Text 2 or 3 on Linux, however, I haven't been able to test it.

It also allows you to move throughout the file from which the dialog was spawned, in case you want to change the insertion point. It uses a DLL on windows to allow you to actually interact with sublime text while the dialog is up, as it would otherwise not be possible, as the dialog box disables its parent window before being completely initialized.

Should at least partially fix #26 and completely fix #16

jesseleite commented 10 years ago

This freezing is my main gripe about ColorPicker as well.

jesseleite commented 10 years ago

Actually, until @weslly implements any pull requests or fixes, how do I install your branch without use of Package Control @BigEndian ?

BigEndian commented 10 years ago

Should be able to install with Sublime Text 3 on OS X by removing ColorPicker via Package Control and then perform the following:

cd ~"/Library/Application Support/Sublime Text 3/Packages"
git clone https://github.com/BigEndian/ColorPicker
cd ColorPicker
git checkout freeze-fix

With Sublime Text 2/3 on Windows and 2 on OS X the only difference should be which path you cd into.

jesseleite commented 10 years ago

@BigEndian Worked perfect, thank you! @weslly This freeze fix is great, maybe you could use @BigEndian's fix?

weslly commented 10 years ago

Thanks for the fix! I'll merge it as soon as I test it.

Btw, sorry for the delay, github don't send emails to notify about pull requests.

BigEndian commented 10 years ago

@JerseyMilker No problem, one person getting the benefit makes it worth doing. @weslly No problem, I'm glad to have my first pull request considered for such a useful project.

Let me know if you find any further issues and I may be able to help in resolving them.

jesseleite commented 10 years ago

Still coming @weslly? :)

weslly commented 10 years ago

Merged. Thanks for the fix! :)

jesseleite commented 10 years ago

Thanks! :D

BigEndian commented 10 years ago

No problem!

weslly commented 10 years ago

@BigEndian Seems like the windows changes broke the plugin for some Windows users: #43

I just tested it on my Windows XP VM and i'm having the same issue. Can you take a look (or revert the Windows code)?

Ghaleon commented 10 years ago

First time on github, sorry for this dumb questions but, where is the fix? D:

My COlorPick does not show up anymore, and @weslly refeferenced this post .s

weslly commented 10 years ago

I temporarily reversed the commit. It should be working again with the new update.

BigEndian commented 10 years ago

@weslly I'll look into it. I can't reproduce it yet, and I never ran into it in a clean windows XP vm. I'll see if I can make it require a lesser .NET runtime as well.

uxDesignStudio commented 10 years ago

Hi! Any news? The color wheel of death is back again! :)

jedevera commented 10 years ago

OS: Windows xp (SP 3), SUBLIME TEXT 3 COLORPICKER: 1.9.2

hi guys i have a problem on installing colorpicker on my ST3. it doesn't show up. i already removed/installed it but still, i'm facing the same problem. im new here in github.

thanks a lot

jesseleite commented 10 years ago

@weslly Can I request to re-open this issue until fix is re-implemented?