weslly / ColorPicker

Color picker for Sublime Text
http://weslly.github.io/ColorPicker
511 stars 108 forks source link

installation not working #65

Closed tjvoll closed 9 years ago

tjvoll commented 9 years ago

I'm trying to install this through package control and there are no errors yet the plugin does not seem to be working. There are no package settings, no new key bindings, etc...

The only file that seems relevant to colorPicker is the linux_colorpicker.py file in Packages/User/ColorPicker/bin

I've tried with both SL2 and SL3 on scientific linux 6.4

Am I out of luck?

weslly commented 9 years ago

Can you try again with the latest release?

tjvoll commented 9 years ago

hey there,

I tried installing again and am getting this error now, Traceback (most recent call last): File "/home/personal_folders/t.voll/Software/sublime_text_3/sublimeplugin.py", line 549, in run return self.run(edit) File "/home/personal_folders/t.voll/.config/sublime-text-3/Packages/ColorPicker/sublimecp.py", line 376, in run self.view.replace(edit, region, '#' + color) TypeError: Can't convert 'bytes' object to str implicitly

On Sun, Mar 8, 2015 at 2:24 PM, Weslly H notifications@github.com wrote:

Closed #65 https://github.com/weslly/ColorPicker/issues/65.

— Reply to this email directly or view it on GitHub https://github.com/weslly/ColorPicker/issues/65#event-248192751.

facelessuser commented 9 years ago

https://github.com/weslly/ColorPicker/commit/cc1e670b173792a07d26308128902715adf081ef should fix that error. The error should only occur when the user dismisses the color picker without accepting the color. At least that is the case the commit fixes. Colors should be decoded to normal strings otherwise.

tjvoll commented 9 years ago

That's odd. The color picker UI wasn't launching for me then. That error was immediately returned after running the command. Still happens in sublime3. In sublime2 it just returns a #. Must be something up with kde.

On Wed, Mar 18, 2015 at 10:59 PM, Isaac Muse notifications@github.com wrote:

cc1e670 https://github.com/weslly/ColorPicker/commit/cc1e670b173792a07d26308128902715adf081ef should fix that error. The error should only occur when the user dismisses the color picker without accepting the color. At least that is the case the commit fixes. Colors should be decoded to normal strings otherwise.

— Reply to this email directly or view it on GitHub https://github.com/weslly/ColorPicker/issues/65#issuecomment-83279777.

facelessuser commented 9 years ago

Ahh, it must be that the linux script is some how not playing nice with your distro then. I assumed you were talking about the just getting the error. The error I fixed didn't actually affect functionality as it only occurred when nothing was to be done anyways.

I think your problem is more likely with the linux script used to show the colorpicker https://github.com/weslly/ColorPicker/blob/master/lib/linux_colorpicker.py. I haven't looked into that specifically, but I imagine with so many different linux distros, it would be difficult to easily provide a script that works on every version of linux in every distro without failing on some.

tjvoll commented 9 years ago

oh, bummer! That's too bad, but I understand.

On Thu, Mar 19, 2015 at 11:07 AM, Isaac Muse notifications@github.com wrote:

Ahh, it must be that the linux script is some how not playing nice with your distro then. I assumed you were talking about the just getting the error. The error I fixed didn't actually affect functionality as it only occurred when nothing was to be done anyways.

I think your problem is more likely with the linux script used to show the colorpicker https://github.com/weslly/ColorPicker/blob/master/lib/linux_colorpicker.py. I haven't looked into that specifically, but I imagine with so many different linux distros, it would be difficult to easily provide a script that works on every version of linux in every distro without failing on some.

— Reply to this email directly or view it on GitHub https://github.com/weslly/ColorPicker/issues/65#issuecomment-83617963.

facelessuser commented 9 years ago

I would try directly running that linux colorpicker script and reporting on what kinds of errors you may be seeing. Maybe it something easy to figure out.

tjvoll commented 9 years ago

ahh, thanks for the suggestion. It appears my distro does not include gi.repository. When I get a minute I'll install that and try again.

On Thu, Mar 19, 2015 at 11:13 AM, Isaac Muse notifications@github.com wrote:

I would try directly running that linux colorpicker script and reporting on what kinds of errors you may be seeing. Maybe it something easy to figure out.

— Reply to this email directly or view it on GitHub https://github.com/weslly/ColorPicker/issues/65#issuecomment-83619277.

facelessuser commented 9 years ago

Cool, just let us know if you were able to resolve the issue by installing the repo. This will enable us to give the same advise to others with similar issues.

tjvoll commented 9 years ago

will do!

On Fri, Mar 20, 2015 at 12:34 PM, Isaac Muse notifications@github.com wrote:

Cool, just let us know if you were able to resolve the issue by installing the repo. This will enable us to give the same advise to others with similar issues.

— Reply to this email directly or view it on GitHub https://github.com/weslly/ColorPicker/issues/65#issuecomment-84063116.