search

weslly / ColorPicker

Color picker for Sublime Text
http://weslly.github.io/ColorPicker
510 stars 109 forks source link

Windows 8.1 Net framework 4.0 #72

Closed CristianH033 closed 9 years ago

CristianH033 commented 9 years ago

In Windows 8.1 can´t open the "win_colorpicker.exe" file in the lib folder because it need net framework 3.

weslly commented 9 years ago

I'll take a look, but meanwhile, you can use the alternate colorpicker:

Open: Preferences -> Package Settings -> ColorPicker -> Settings - User

And set "win_use_new_picker" to false.

CristianH033 commented 9 years ago

thank you from Colombia :)

facelessuser commented 9 years ago

Yeah, the code was built with an older .net. I can try and build with a newer one. I avoided it because I didn't want to have to upgrade the entire codebase if there were incompatibilities. I need to publicly post it...

facelessuser commented 9 years ago

Looks like it builds fine in .NET 4.5.1 and seems to work fine, so I will make a new pull request with latest version when I get a chance. I will also post the project somewhere so people can get access to it.

facelessuser commented 9 years ago

Rebuilt win_colorpicker.exe with .NET 4.5.1 https://github.com/weslly/ColorPicker/commit/2975d908a2684beea6438285acc093ee075915bd. So when @weslly wants to release it, you should get the new one. Within the next week, I will try and upload the project to bitbucket or something.

weslly commented 9 years ago

@facelessuser I tested the new binary on Windows XP (32bit) and got this error:

OSError: [WinError 193] %1 is not a valid Win32 application
facelessuser commented 9 years ago

Hmm. I'll check it out. Maybe I accidentally built it as a 64 bit program.

facelessuser commented 9 years ago

Yeah, it looks like I built it as a 64 bit. My bad. I'll rebuild and confirm its 32 bit and then recommit.

facelessuser commented 9 years ago

I apologize about not getting this updated yet. It is on my list for this weekend.

weslly commented 9 years ago

@facelessuser No worries, thanks for your help :)

facelessuser commented 9 years ago

Updated app as a 32 bit app https://github.com/weslly/ColorPicker/commit/371f601f1182845b79d61e5982af03107669d641.

Hopefully that fixes things.

weslly commented 9 years ago

@facelessuser Thanks for the update! I only had time to reinstall a VM with win XP now, and it seems to be working without any problems.

weslly commented 9 years ago

@facelessuser Actually, for some reason package control wasn't getting the latest release so it worked with the previous build before 2975d90.

Since it worked for you at newer windows versions (with both 32 and 64 bit) and only one person (besides me) had this bug, I think it is safe to leave it as it is. Windows XP is almost 15 years old and not even Microsoft supports it anymore. Also, there's the ctypes alternative which works just fine.