search

wesm / feather

Feather: fast, interoperable binary data frame storage for Python, R, and more powered by Apache Arrow
Apache License 2.0
2.74k stars 167 forks source link

Remove .NOTPARALLEL #373

Closed hadley closed 5 years ago

hadley commented 5 years ago

From CRAN:

.NOTPARALLEL is a GNUism, and these packages do not declare GNU make -- there are other parallel makes available on R platforms where it will not work as intended if it is actually needed. As 'Writing R Extensions' has warned for quite a while now ....

For feather, AFAICS the Makefile is one of many unused files.

hadley commented 5 years ago

cc @jimhester can we remove this?

jimhester commented 5 years ago

Looks like we could .Rbuildignore the Makefile entirely, the R package is not using it.

hadley commented 5 years ago

Do you have time to make that change and do a quick release? It's currently causing WARNINGs