search

wesnolte / jOrgChart

A jQuery plugin to draw tree-like structures such as OrgCharts.
992 stars 674 forks source link

Tree reordering by id's #6

Closed Shinruchan closed 12 years ago

Shinruchan commented 12 years ago

Hi,

after using tree, I figured out that some nodes can have same name and tree couldn't handle it.

So I modified code a little that it supports ids which can be unique for each node.

This update enables:

Aleks

wesnolte commented 12 years ago

Thanks very much for the help!

crebma commented 12 years ago

This merge breaks backward compatibility- you must have an id on each node to use this plugin now.

wesnolte commented 12 years ago

Hmmm, I missed that sorry. I was too busy checking that it maintained the class attribute copy. I'll roll back a version.

crebma commented 12 years ago

No worries, just wanted to let you know. I don't know how you feel about testing, but I'd be happy to spend some free time wrapping jOrgChart with jasmine if you are interested? On Feb 7, 2012 11:11 AM, "Wes" < reply@reply.github.com> wrote:

Hmmm, I missed that sorry. I was too busy checking that it maintained the class attribute copy. I'll roll back a version.

Reply to this email directly or view it on GitHub: https://github.com/wesnolte/jOrgChart/pull/6#issuecomment-3850702

wesnolte commented 12 years ago

That would be pretty epic :) I'm part of a team leading a startup so I don't get as much time for open source dev as I'd like.

Shinruchan commented 12 years ago

Ups, I didn't even think there might be problem with compatibility. If you don't mind I'd like to improve update to support non-id trees.

wesnolte commented 12 years ago

I've rolled back the functionality so that non-id trees should work. Go ahead an make any changes you think are wise :) I'll accept the pull request.