wesnoth / haldric

Wesnoth 2.0, being developed in the Godot engine.
https://www.wesnoth.org
368 stars 48 forks source link

mods (insecure, but prototype) #155

Closed jay20162016 closed 3 years ago

jay20162016 commented 3 years ago

Plus, most major games with modding don't have sandboxing anyway.

Pentarctagon commented 3 years ago

As long as someone volunteers to explain to players when an add-on they downloaded from our servers deleted a bunch of their files or other malicious actions.

Zireael07 commented 3 years ago

I don't think .pck files can delete files?

jay20162016 commented 3 years ago

.pck files can perform malicious actions... but this is just a prototype. Because Godot (as of the moment) has no sandboxing, this is probably the best we can do. However, I don't think we need someone to explain malicious mods, as long we provide a notice that mods can be malicious. And again, most major games with modding support do this too.

jay20162016 commented 3 years ago

Whops, accidentally pushed some unrelated stuff...

jay20162016 commented 3 years ago

I'll split the pr in to event parts and mod parts.