search

wesnoth / wesmere

Website design for The Battle for Wesnoth used since mid-July 2017.
https://www.wesnoth.org/
Other
7 stars 8 forks source link

Modifying internal links #15

Closed clockback closed 5 years ago

clockback commented 5 years ago

Adding github.com/wesnoth/wesnoth as "internal link"

clockback commented 5 years ago

This is so that citations on wiki.wesnoth.org can link to their respective GitHub files without the icon indicating that it is an external link.

irydacea commented 5 years ago

GitHub links are external, though. Why should we lie about this fact?

clockback commented 5 years ago

It is only an external link in so far as sourceforge.net/projects/wesnoth is an external link. To my knowledge, the special CSS for external links is presumably to indicate that the user who follows the link is aware that they are going to some place that is external to the de facto official Wesnoth domain. The GitHub repository for Wesnoth seems to be within that domain, just as the sourceforge project is, so I don't believe anybody is deceived.

But besides the justification for why it isn't inappropriate, I believe it would be undesirable to have extra CSS styling in a citation list on the wiki.

irydacea commented 5 years ago

I don't think the citation list argument is particularly relevant. Wikipedia doesn't shy away from including external links in citation lists for example.

I'd like @Vultraz opinion on this. I didn't remember that we made an exception for SF.net.

clockback commented 5 years ago

What you mention about Wikipedia is true. At the moment, if I cite a scenario, I format it like this:

A Summer of Storms, The Rise of Wesnoth

The problem is that introducing external links adds two icons. In the first link (to the scenario), it adds "</>" on the left, whereas in the second link (to the campaign), it adds a box with an arrow on the right. See this article for reference.

The icons are different, and though it is hard to articulate, I personally don't like it from a visual standpoint. Of course, if I am alone in this preference, I don't mind leaving things as they are. :)

GregoryLundberg commented 5 years ago

The issue is the definition of "internal" and "external".

From the point of view of the Wiki pages, themselves, SF, GH, etc., are all "external" because they are on different web servers. Technically, even the Forums are "external" because they are not part of the Wiki, itself.

But, from the point of view of the Wesnoth Project, those pages are "internal" since they are official parts of the project, no matter where they reside.

My feeling is the latter is better for our purposes.

Whichever definition is choosen, however, the underlying point from the OP stands: we should, at least, be consistent. If SF is "internal" so is GH; if GH is "external" then SF should be as well.

irydacea commented 5 years ago

Going for aesthetics here above everything else since I see that GH links are becoming more common.