wesnoth / wesmere

Website design for The Battle for Wesnoth used since mid-July 2017.
https://www.wesnoth.org/
Other
7 stars 8 forks source link

wmlunits: Sidebar menu popups need column layout #2

Closed irydacea closed 7 years ago

irydacea commented 7 years ago

In many cases, the race menu popups may overflow the page revealing the empty yellow space below the site footer, due to them being too tall. To alleviate this, we may use CSS column layouts.

An early attempt at this using styling on the markup wmlunits produces as of wesnoth/wesnoth@b96dc224d0c7 shows that the idea should work, but it requires major markup changes because of Firefox not supporting the column-span property yet. Without it, short menus tend to look extremely weird if the column count is greater than what the menu should actually need:

spectacle d16683

It may be possible to instruct wmlunits to annotate popup menus with extra classes to decide how many columns we need, but there's still the problem of the popup label (itself part of the list) being dragged into the first column:

spectacle r16683

So, preferably, the menu should be reworked as a <div> containing a <div> for a label (like it was already the case for the Language menu, and the elements below in a column-layout list.