New page for queries - Githubissues

wesnoth / wesnoth-multiplayer-data-dashboard

This is a dashboard that allows you to query and visualize data that the Wesnoth Project collects about multiplayer games played on the official server.

2 stars 0 forks source link

New page for queries #15

Closed max-torch closed 7 months ago

max-torch commented 7 months ago

In this PR

A page navigation bar has been added to the header section
A new page called Query, containing features from https://github.com/wesnoth/wesnoth-multiplayer-data-dashboard/tree/Table-and-Figures-Combined-early-build, has been created.
On the Query page, when data is about to be fetched from the MariaDB database, if the number of data rows that would be fetched exceeds 5000, the data will not be fetched/processed and a popup will inform the user to reduce the scope of their query.
Callbacks for UI components that are defined across three files: layout.py, aggregate_statistics.py, and query.py are all inside of app.py and have been separated from each other using comments.

Screenshots

Page Navigation Bar

Query Page

Popup when the data to be fetched is too large

Pentarctagon commented 7 months ago

What is the Query Page screenshot meant to show?

max-torch commented 7 months ago

What is the Query Page screenshot meant to show?

It is showing how the new page, called Query, looks like. In this page, there is a date range picker, a table whose data can be exported, a total games card, and a histogram.

Selecting a date range will trigger fetching data that will then be shown on the table and visualized in the histogram

soliton- commented 7 months ago

This PR can be tested on https://replays.wesnoth.org/dashboard-dev/query/.

soliton- commented 7 months ago

Btw, I think design wise it'd look nicer with the games count on the top right next to the date range.

max-torch commented 7 months ago

Just added 5 commits that address all the latest feedback @soliton- Commit names (expand full commit name) accurately reflect commit contents. Ready for another review.

soliton- commented 7 months ago

The limit can continue to default to 5000. Just a config value overrides it. Otherwise looks good to me.

max-torch commented 7 months ago

Will merge to main in one day.

soliton- commented 7 months ago

I would consolidate all the config handling in one function including the env and defaults instead of duplicating that.

max-torch commented 7 months ago

All tests are passing when run locally.

max-torch commented 7 months ago

I would consolidate all the config handling in one function including the env and defaults instead of duplicating that.

Let's have a new issue #16 and PR for this

max-torch commented 7 months ago

This PR closes #8