Closed max-torch closed 7 months ago
What is the Query Page screenshot meant to show?
What is the Query Page screenshot meant to show?
It is showing how the new page, called Query, looks like. In this page, there is a date range picker, a table whose data can be exported, a total games card, and a histogram.
Selecting a date range will trigger fetching data that will then be shown on the table and visualized in the histogram
This PR can be tested on https://replays.wesnoth.org/dashboard-dev/query/.
Btw, I think design wise it'd look nicer with the games count on the top right next to the date range.
Just added 5 commits that address all the latest feedback @soliton- Commit names (expand full commit name) accurately reflect commit contents. Ready for another review.
The limit can continue to default to 5000. Just a config value overrides it. Otherwise looks good to me.
Will merge to main in one day.
I would consolidate all the config handling in one function including the env and defaults instead of duplicating that.
All tests are passing when run locally.
I would consolidate all the config handling in one function including the env and defaults instead of duplicating that.
Let's have a new issue #16 and PR for this
This PR closes #8
In this PR
layout.py
,aggregate_statistics.py
, andquery.py
are all inside ofapp.py
and have been separated from each other using comments.Screenshots
Page Navigation Bar
Query Page
Popup when the data to be fetched is too large