search

wesnoth / wesnoth-multiplayer-data-dashboard

This is a dashboard that allows you to query and visualize data that the Wesnoth Project collects about multiplayer games played on the official server.
2 stars 0 forks source link

consolidate config #17

Closed max-torch closed 6 months ago

max-torch commented 7 months ago

closes #16

All the loading of config.json inside of app.py is consolidated. However, there is a loading of config.json inside of layout.py that seems to be unavoidable because the keyword arguments of the Dash app object constructor can only be passed during object instantiation and not updated post-object-instantiation. I wrote a comment for any future devs to understand the reasoning. I think this is something we can easily live with.

max-torch commented 7 months ago

All tests pass, run locally image

max-torch commented 6 months ago

I will merge this PR a week from now