search

wesnoth / wesnoth

An open source, turn-based strategy game with a high fantasy theme.
https://www.wesnoth.org/
GNU General Public License v2.0
5.45k stars 998 forks source link

[unlock_view] in add-on scenario doesn't unlock view #2145

Closed singalen closed 6 years ago

singalen commented 6 years ago

I installed a "Flight to liberty" campaign. Its first scenario has tags like: 

    [lock_view]
    [/lock_view]
    {HIGHLIGHT_IMAGE 12 30 items/gohere.png ()}
    [unlock_view]
    [/unlock_view]

The view locks and doesn't unlock.

(Discord channel)

Pentarctagon: so if [unlock_view] isn't actually unlocking the view, that might be a wesnoth bug.

Vultraz: yeah, if it doesn't work, file a bug report and assign to celmin

CelticMinstrel commented 6 years ago

Why is this assigned to me, exactly?

Vultraz commented 6 years ago

I cannot reproduce this. I think it must be an issue with the addon.

GregoryLundberg commented 6 years ago

Closing this as invalid report.

The HIGHTLIGHT_IMAGE macro includes a scroll_to which occurs even when the view is locked.

Testing mainline such as in NR where [lock_view] properly prevents scrolling during start-event dicusssions (as an example) shows view locks and unlocks.