Open sevu opened 5 years ago
enables some Lua debugging mechanisms
from looking at the code it seems it just replaced wesnoth.require with a alias of wesnoth.dofile ? If that the case we should just remove it since this can actually break lua code and is not really helpful for debugging (files will be reloaded anyways when reloading a game)
Is it about a Lua package called package?
Yes iirc this in particular enables functions to load binary files (.dll on windows) do define lua functions via c++, basicially enabling it to run aribiary binary code.
"Adds the Option" would mean that this is an Switch which adds an Option… if so, where/how does one enable the added Option? I couldn't see anything ingame… but I remember some screenshot from 1.13.
If you run wesnoth --debug --clock
there'll be a "Clock" button under the "Quit" button on the title screen. This is a debug thing, the man page should make that clear. We could probably create a new "Options for debugging and developers" section and move some option flags to it, like there's a "Options for multiplayer" section.
The Manpages are part of the translation process, the translators of the manpages should understand what these options mean, without knowing the code.
A few command options are a bit unclear: (Please check the boxes if you can resolve one)
[ ] --clock Adds the option to show a clock for testing the drawing timer. "Adds the Option" would mean that this is an Switch which adds an Option… if so, where/how does one enable the added Option? I couldn't see anything ingame… but I remember some screenshot from 1.13.
[ ] --debug-lua enables some Lua debugging mechanisms Maybe this can be a bit more clear, i.e. (how) can this option help to debug UMC written in Lua.
[ ] --plugin script (experimental) load a script which defines a Wesnoth plugin. Similar to --script, but Lua file should return a function which will be run as a coroutine and periodically woken up with updates. People will associate plugin with add-on, which this is not.
[ ] --script file (experimental) file containing a Lua script to control the client control the client = ? Is worded nice though.
[ ] --unsafe-scripts makes the package package available to lua scripts, so that they can load arbitrary packages. Do not do this with untrusted scripts! This action gives lua the same permissions as the wesnoth executable. Is it about a Lua package called package?
[ ] --new-widgets there is a new WIP widget toolkit, this option enables it. This is very experimental, don't fill bug reports since most are known. Parts of the library are deemed stable and will work without this switch. After GUI2 is used now nearly everywhere, this should be rephrased. What does this enable?
[ ] --label: I guess it has nothing to do with AIs and sets the name of the side shown in the game overview dialogue. Maybe also the leaders name. Need to check it.