wesnoth / wesnoth

An open source, turn-based strategy game with a high fantasy theme.
https://www.wesnoth.org/
GNU General Public License v2.0
5.45k stars 998 forks source link

SotA Slipping Away - Load Game - minimap is shown after the scenario is loaded #5270

Open celerini opened 3 years ago

celerini commented 3 years ago

Game and System Information

Describe the bug

When opening previously saved SotA S01 in fresh game the minimap is not generated and the game complains about unknown tile:

20201109 19:41:43 error config: Error while loading the map: Unknown tile in map: (Rb^Fync) 'Rb^Fync'

After loading SotA S01, the bug is gone (the tile is known and a minimap for saved game appears).

To Reproduce

Steps to reproduce the behavior:

  1. start a new SotA campaign
  2. save
  3. quit the game
  4. ctrl+o to load game

Expected behavior

minimap for in-game campaing save is shown

Savefiles

SotA-Slipping Away-Auto-Save1.gz

Wedge009 commented 3 years ago

When loading the supplied save file from 1.15.6 (I assume that's the current released development version) I can see the error message in stderr but otherwise I don't see anything amiss - I still see the mini-map generated. When I start a fresh SotA campaign I don't see any error message nor is the mini-map broken for me.

I'm running 1.15.7+dev (3f6645e3c43) and I understand 1.15.7 may be released soon, so perhaps this will be resolved in that release.

celerini commented 3 years ago

I did not express clearly. I meant the minimap in the Load Game window not in the game UI.

Do you see the minimap in the Load Game window when you click on the SotA save in freshly started game?

Wedge009 commented 3 years ago

Oh I see, you're referring to the load game dialogue. Yes, I think that's an issue that's been reported before - for more than just SotA. Unfortunately I can't find that other issue right now - perhaps it's the case whenever there's an unrecognised tile or otherwise an error in processing the map the mini-map preview is disabled.

stevecotton commented 3 years ago

I'm not going to log a separate issue for it, but there's a todo lurking in SotA's _main.cfg:

{campaigns/Secrets_of_the_Ancients/utils/terrain-compat.cfg} # remove this after BfW 1.15.6 is released
Wedge009 commented 2 years ago

That's now reported in #6591.

Wedge009 commented 4 months ago

I'm inclined to close this. Retesting in 1.18.0, the mini-map shows, as does my game save from 1.16. Generally, I think the mini-map is hidden for scenarios with shroud, but they may be shown if only fog is used.

Wedge009 commented 4 months ago

Hmm, this might be something specific to SotA S1 after all. I just realised the issue specifies mini-map being shown before loading the save file, but not before. I tried another scenario that has shroud and even after loading the mini-map doesn't show.

Wedge009 commented 4 months ago

8351 requests the reason for the mini-map not showing be made explicit.