search

wesnoth / wesnoth

An open source, turn-based strategy game with a high fantasy theme.
https://www.wesnoth.org/
GNU General Public License v2.0
5.48k stars 1.01k forks source link

show a message when nothing exists to migrate #9025

Closed Pentarctagon closed 2 months ago

stevecotton commented 3 months ago

This text assumes that the user already understands what the button is meant to do, but seeing this error likely means that they pushed the button wondering what it did, as I'd expect them to know whether they'd played an old version on a PC (recently enough that they haven't customised the new install.

Instead of making this a new pop-up, I think it would be better to show the migration dialog, thus getting the explanation that's already in that dialog, and put the error message in place of the list (IIRC some of the list widgets have already support for a string to show when they're empty), along with greying out the "OK" button.

Pentarctagon commented 3 months ago

I think if they clicked a button called Migrate which has the associated text "Re-open the version migrator dialog" and the message added here says that saying that there are no previous versions to migrate data from, then it's very clear what's being talked about.

stevecotton commented 3 months ago

It's clear to people who've understood what "migrate" means in this context, but that's not a given. For people who haven't, a description that uses other words helps, but simply repeating the word "migrate" or "migration" doesn't make it any clearer - and the target audience for this error message is people who either haven't understood it, or who've forgotten which PC their 1.16 installation was on.

Pentarctagon commented 3 months ago

That sounds like something that would be better shown as a tooltip rather than opening an empty dialog that they can't do anything with.

Pentarctagon commented 2 months ago

Also, I'm not sure what different information the dialog is giving that the new popup isn't. The popup says:

There are no other previous versions which data can be migrated from

The dialog says:

Choose which version of Wesnoth to import your data from

Aside from "migrate" vs "import", they give essentially the same information to someone who has no idea what it does.

stevecotton commented 2 months ago

I think just using a different word to "migrate" helps. Maybe use this wording instead:

"No Other Version Found", "This would import settings from a previous version of Wesnoth, but no other version was found on this device."

Either way, I'll stop blocking this. Please merge, either with or without the suggested change.

Pentarctagon commented 2 months ago

Updated to that wording.