Closed soliton- closed 1 month ago
Sounds like it's probably related to #8366
The referenced line is https://github.com/wesnoth/wesnoth/blob/31658e2587d1a0ba230d2dcf562c5369ffb5b045/data/campaigns/World_Conquest/lua/map/scenario_utils/bonus_points.lua#L389
it creates a filter that uses f.find_in()
This line
also pushes nil on the lua stack, when its only supposed to check in that case.
I'm curious where the [string "..."]:8: in function <[string "..."]:8>
in the stacktrace comes from, does anyone know ?
Quite likely, but then why is its twice in the stack, once at the top and once at the bottom?
This line [...] also pushes nil on the lua stack, when its only supposed to check in that case.
So could the fix be to add a pop here?
Quite likely, but then why is its twice in the stack, once at the top and once at the bottom?
That… I can't explain…
So could the fix be to add a pop here?
That could work, changing the -1
to a -2
in that line might also work.
(Modified is a lie, it's added because of untracked files for some reason)
Not necessarily a lie - try making sure the sub-modules are up-to-date as well.
Sounds like it's probably related to #8366
Confirmed it's 19f3682bdf0962af0a5afdb1a53ab9d49b345b9c (1.19.2) that causes this.
@CelticMinstrel can you look into fixing this then?
Probably, unless @gfgtdf wants to do it?
Would be good to get this fixed or revert 19f3682 for 1.19.4.
Do we have a plan on when 1.19.4 happens?
Anyways I committed the suggested change via my phone, so it's not really tested, I don't really have doubts that my change fixes a bug in the code, but still it would be nice if someone could verify whether it actually fixes the given case in this report.
I'm not sure what that change is supposed to do but at 3af690331a5, I can start a 1-player WC game without apparent issue.
Very good, thank you
Game and System Information
Description of the bug
Steps to reproduce the behavior
Select Multiplayer -> Local Game -> Multiplayer Campaigns -> World Conquest
Expected behavior
World Conquest starts without error.
Additional context
No response