Merge the `wesnoth` and `wesnoth-lib` text domains

wesnoth / wesnoth

An open source, turn-based strategy game with a high fantasy theme.

https://www.wesnoth.org/

GNU General Public License v2.0

5.53k stars 1.02k forks source link

Merge the `wesnoth` and `wesnoth-lib` text domains #9299

Open stevecotton opened 2 months ago

stevecotton commented 2 months ago

I'm making an issue for discussion rather than asking for it to happen in #8731, but am in favor of merging the two domains. I think keeping the name wesnoth-lib would make sense, or choosing a new name, but I'd like to avoid just calling something wesnoth.

From the discussion in #8731:

I'm still not sure whether they should be in wesnoth or wesnoth-lib, but we should have the complete set of strings for showing the properties of a unit, all in one text domain or the other.

AFAIK the reason for the split into wesnoth and wesnoth-lib is long gone so we could just merge the two.

stevecotton commented 2 months ago

There are 3 strings which are currently only used as a singular in one domain, but are used as a plural in the other one.

The uses of msgid "Attack" are a bug. It's used as a verb on a button label in data/gui/themes/default/window/unit_attack.cfg, but as a noun (with plural) in the sidebar in reports.cpp.

The other two seem OK - they're used in two places in the add-on manager, and one of those places is a context where it's only handling a single add-on.

msgid 'The following add-on appears to have publishing or version control information stored locally, and will not be removed:'
msgid 'The following add-on could not be deleted properly:'

CelticMinstrel commented 2 months ago

If you don't want to call it just wesnoth, I suppose I'd suggest something like wesnoth-core.

stevecotton commented 2 months ago

Not fond of mainline-core, despite it probably being the most fitting name for the mix of stuff that's in it, because we already have the "Mainline core" subset of the text domains. Maybe wesnoth-engine or wesnoth-main?

CelticMinstrel commented 2 months ago

Not sure where you got mainline-core from. wesnoth-main also sounds fine.

soliton- commented 1 day ago

When merging wesnoth and wesnoth-lib there should also be no reason to leave wesnoth-editor separate. AFAICT wesnoth-lib and wesnoth-editor exist because the editor was a separate program at some point and shared strings with wesnoth (via wesnoth-lib).

Wedge009 commented 1 day ago

Given what I observed in #9492, that makes sense to me. Thanks.