search

weso / hercules-ontology

Development of the Ontology and its Continuos Integration for the Hercules project.
https://herculescrue.github.io/ib-hercules-ontology/current/asio.html
GNU General Public License v3.0
0 stars 5 forks source link

Added instances for competency question #51. #93

Closed sofimrtn closed 4 years ago

sofimrtn commented 4 years ago

Added two new researchers and two publications for each one of them, as well as a new edited publication. Also added roles to existing researchers.

thewillyhuman commented 4 years ago

@alejgh can you please review?

thewillyhuman commented 4 years ago

BTW is there any issue relates to this PR?

alejgh commented 4 years ago

BTW is there any issue relates to this PR?

This closes CQ038 associated to the issue #39

I think we should change the title of the PR, since it not only involves adding the instances but also creating the SPARQL query to solve the CQ (see workflow below).

The workflow is as follows:

My idea is to keep the same steps for following PRs associated to competency questions, but maybe the person that works on each step changes (e.g. sometimes I will work on adding the instances to the file and Wikibase and maybe @labra or @sofimrtn work with the SPARQL query...).

@thewilly do you think that we should make separate PRs to insert the instances and to develop the SPARQL query? I usually like to make a PR per issue, and that's why my original idea was to do both things in this PR, but I'm open to suggestions.

thewillyhuman commented 4 years ago

No no problem with that, just asking to link to the issue but one PR can be linked to multiple issues and viceversa

sofimrtn commented 4 years ago

Fixed syntax errors. Turtle validator confirms. Copy-pasting does not work too good sometimes when it comes to semicolons. Also thanks for the triple quotation info, had no idea :)

alejgh commented 4 years ago

I have created a SPARQL query to solve the CQ: https://tinyurl.com/y95hnf8g

If you allow me write access to your fork, I can update the PR with the query and close this.

thewillyhuman commented 4 years ago

@alejgh you are able to add more commits to sofimrtn/hercules-ontology.

alejgh commented 4 years ago

@alejgh you are able to add more commits to sofimrtn/hercules-ontology.

Yes, I needed her to add me as a collaborator in her fork. Now everything is ready.

alejgh commented 4 years ago

I have moved the remaining competency questions to the doc folder. This will also close #102