Enable search/replace in text editors

weso / rdfshape-client

Web client for RDFShape API with human-friendly validations and visualizations.

https://rdfshape.weso.es

MIT License

10 stars 5 forks source link

Enable search/replace in text editors #46

Closed ulitol97 closed 2 years ago

ulitol97 commented 3 years ago

Reference/proof of concept: https://codemirror.net/demo/search.html

mistermboy commented 3 years ago

Both YASHE and Yate now support search and replace. (https://github.com/perfectkb/yate/pull/2) However, I have been looking at rdfshape-client and it seems that Yate is not in use, am I wrong? @labra @ulitol97

ulitol97 commented 3 years ago

Awesome! About the usage of Yate, I don't know if @labra has anything to add but afaik you are right. I'm modifying the codebase to use Yate whenever the input data format is turtle.

labra commented 3 years ago

I think I switched off Yate because it was giving me some problems and I wanted the syntax highlihgting functionality to be quickly available.

If you are able to make it work again, it would be great.

ulitol97 commented 3 years ago

I'm my last PR I've made changes so that we use Yate again. I've also updated Yate to its latest version in order to implement the search/replace functionality.

I've noticed a couple of issues:

Search/replace is available in Yashe but not in Yate.
Replace is not working on Yashe (an error in shown in console whenver Ctrl + Shift + F is used)

@mistermboy any help/clues? I'm probably missing something.

Here is an example of a ShEx validation using both Yate and Yashe.

mistermboy commented 3 years ago

Solved in #54