search

weso / shapes-rs

RDF data shapes implementation in Rust
https://www.weso.es/shapes-rs/
Apache License 2.0
23 stars 1 forks source link

Add more code quality checks #40

Closed MarcAntoine-Arnaud closed 3 weeks ago

MarcAntoine-Arnaud commented 4 weeks ago

Configure cargo fmt and cargo clippy will help to increase code quality.

labra commented 4 weeks ago

Indeed, that was in my TODO list...I saw you did a PR for that...would that PR solve this issue?

MarcAntoine-Arnaud commented 4 weeks ago

Yes it will address it.

labra commented 4 weeks ago

Thanks!, I merged your PR...I appreciate the cleaning of the code you hace accomplished...I hope I keep maintaining those rules...however, I am new with some of the tools, I am not sure if my future commits will automatically keep the quality checks or not...

I will leave this issue open by now until I have more confidence with the new quality checks...

Thanks a lot for the your contributions.

MarcAntoine-Arnaud commented 4 weeks ago

Hi, Yes it's good to have these kind of tools. As you've merged, the format is now required to merge. For clippy, the goal is to finalise, it will be requested for each MR too then.

Regards

MarcAntoine-Arnaud commented 3 weeks ago

Hi @labra, I have complete the clippy update. So now it will requires to be fine with it once it will be merged ;-)

labra commented 3 weeks ago

Thanks a lot for the PR...I have merged it already and will close this issue.