search

weso / sparkwdsub

Spark processing of wikidata subsets
MIT License
0 stars 3 forks source link

changing the default value of the keep shapes argument #22

Closed brett--anderson closed 2 years ago

brett--anderson commented 2 years ago

The keep shapes parameter doesn't take any argument, it just seems to include shape debug information if it's present, or omit it if the parameter isn't present. But the parameter's default value is set to true, so there doesn't seem to be any way to turn this off. With this change there is no shape information when the argument isn't present and shape information when it is.

labra commented 2 years ago

Thanks for the PR, indeed, it can be changed.