search

wesovilabs / orion

A next-generation testing tool. Orion provides a powerful DSL to write and automate your acceptance tests
http://www.wesovilabs.com/orion
MIT License
48 stars 6 forks source link

feat: action `sleep` #12

Closed cdmatta closed 3 years ago

cdmatta commented 3 years ago

Added action sleep as per https://github.com/wesovilabs/orion/issues/9

The timeout example scenario utilizes string for example "10s", however the documentation mentiones timeout = 10s

Screenshot from 2021-03-04 00-00-25

Screenshot from 2021-03-04 00-01-13

Given code is likely to be correct than doc, I went with that. Even the hcl plugin in my IDE was giving me error with duration = 1s

I can fix the documentation next if this is fine.

codecov[bot] commented 3 years ago

Codecov Report

Merging #12 (f4baf05) into master (e116ada) will increase coverage by 0.41%. The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   37.88%   38.30%   +0.41%     
==========================================
  Files          40       42       +2     
  Lines        1090     1120      +30     
==========================================
+ Hits          413      429      +16     
- Misses        641      652      +11     
- Partials       36       39       +3
Impacted Files Coverage Δ
actions/block/block.go 41.30% <ø> (ø)
actions/sleep/decoder.go 40.00% <40.00%> (ø)
actions/sleep/action.go 80.00% <80.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e116ada...f4baf05. Read the comment docs.

ivancorrales commented 3 years ago

That would be awesome @cdmatta ! It looks great for me