search

wessberg / DI-compiler

A Custom Transformer for Typescript that enables compile-time Dependency Injection
MIT License
80 stars 7 forks source link

Generics and TypeScript limited to 4.6.* #17

Closed cmidgley closed 2 years ago

cmidgley commented 2 years ago

This pull addresses two things: 1) Support for generics, as per #11.
2) Limits TypeScript in package.json to ~4.6.4, as recently released 4.7 does not currently work. Obviously back out this change when 4.7 is supported.

Passes all tests, and change #1 has been in my rig for a couple months now.

I did bump the version number and add a change log. Sorry if this was inappropriate - some smaller projects like it when I assist with the details, others find it a major faux pas! In the change log I refer to the labeled version, which of course does not exist yet. Glad to fix the repo to remove that if you prefer.

cmidgley commented 2 years ago

Sorry about the closures ... turns out git was very unhappy with my branch name (origin, stupid choice ... had to do with wanting to keep all my prior work and create a fresh branch origin to your code so I could create a clean pull for you). Renaming the branch caused github to close both PR's. New PR's coming...