Support for classes that extend DIContainer with new option - Githubissues

wessberg / DI-compiler

A Custom Transformer for Typescript that enables compile-time Dependency Injection

MIT License

82 stars 7 forks source link

Support for classes that extend DIContainer with new option #29

Closed cmidgley closed 4 months ago

cmidgley commented 5 months ago

New feature:

Support implementations that extend DIContainer: Adds a new environment variable DI_COMPILER_CLASS_NAME (and associated di.diClassName option) to specify one or more names of classes that inherit from DIContainer. This allows one to extend DI with custom functionality without needing to request changes to the repo (and allowed me to rip out some likely wanted junk from a prior pull request and implement it in my own class).

Bugs fixed:

Options with transformers: Unlike loaders, transformers use the di() call which did not allow any of the environment variable / di.xxx options to be used. This adds functionality to the di() call to get and apply options from resolveOptions.
Adust DIProgramOptions type to be consistent with use: The DiProgramOptions interface specified program: TS.Program, which is lacking the extensions added for options. Adjusted to match implementation by changing to program: TS.Program & DiIsolatedModulesOptions.
Retain identifier options: The identifier option was being dropped in the getBaseVistorContext function with identifer: []. Retained the options by changing to identifier: rest.identifier ?? [].

This passes all test cases, but no new test cases added as I didn't see any test code that tested options.

cmidgley commented 4 months ago

I no longer need this. Unless you would like it, I'm taking it down.