search

wesselt / bunq2ynab

Upload bunq transactions to ynab
Other
78 stars 22 forks source link

Restructure the repository with separate `test` and `src` directories. #27

Closed anubhavcodes closed 4 years ago

anubhavcodes commented 4 years ago

Hi,

I would like to propose a change to change the directory structure in a way that it is possible to have the source in one place and then add tests another module which contains unit tests for the code.

I would also propose to add separate bunq and ynab into their own src directories.

If you agree to this, I can work on this in my fork and raise a PR.

Thoughts?

wesselt commented 4 years ago

Hi Anubhavcodes,

Thanks for your proposal. If you see an opportunity to add meaningful tests that would be welcome. Creating a separate test directory is fine. The python scripts that are intended to be invoked from the command line should remain in the root of the project.

The "config" branch is currently in its last phase of testing and I'll merge it to master soon. If you want to work on a PR then I would base it on the config branch.

Kind regards, Wessel

anubhavcodes commented 4 years ago

Thanks a lot @wesselt for your reply. I will wait for your config branch to be merged into master and will revisit this issue later.

Just FYI, we can still have a cli entry point that can be called from the root of the directory like python -m bunq2ynab <entrypoint> and still call them from a src directory. But we can talk about it later. ;)

I am closing this issue for now. :)