search

wesselt / bunq2ynab

Upload bunq transactions to ynab
Other
75 stars 20 forks source link

adds sleep for get_notification_filters #45

Closed rubenvitt closed 1 year ago

rubenvitt commented 1 year ago

ref: #44

rubenvitt commented 1 year ago

sorry, had some problems with my Git-setup 😂

wesselt commented 1 year ago

Hmm, looks to me like there's no guarantee that the 4th call will be to the notifcation filter.

Might be better to modify the call() function in lib/bunq.py to make sure the 3rd last call was 3 seconds old. What do you think about that?

rubenvitt commented 1 year ago

Your comment makes totally sense. I think the different rate limits should be implemented. What do you think about it?

GET 3/3 seconds
POST 5/3 seconds
PUT 2/3 seconds
wesselt commented 1 year ago

Sure, that's even better! There are already separate functions for GET, POST and PUT at the end of lib/bunq.py

rubenvitt commented 1 year ago

I'm implementing Python not very often, hopefully this one is good enough.

wesselt commented 1 year ago

Looks good, merged in! Thanks