search

westberliner / checksum

Plugin for Nextcloud and ownCloud to create hashes of files.
GNU General Public License v3.0
29 stars 15 forks source link

CRC-32 checksum is not correct #32

Closed Somebodyisnobody closed 3 years ago

Somebodyisnobody commented 5 years ago

The CRC-32 algorithm is not equal if i check the same file with https://emn178.github.io/online-tools/crc32_checksum.html and 7-Zip. I tested that with 2 files.

The other algorithms are correct

Manorhos commented 5 years ago

PHP provides two different CRC32 algorithms and the crc32b variant appears to be more widely used as a file checksum, but we use the crc32 variant. So either we need to add CRC32b as an additional checksum choice or we could just switch over to crc32b altogether. Personally, I'd prefer the latter.

Somebodyisnobody commented 5 years ago

Oh I didn't now that, thought CRC32 = CRC32 😃

westberliner commented 3 years ago

I added crc32b as well.