search

westberliner / checksum

Plugin for Nextcloud and ownCloud to create hashes of files.
GNU General Public License v3.0
29 stars 15 forks source link

Refactor deprecations, improve code style and drop owncloud support #47

Closed st3iny closed 3 years ago

st3iny commented 3 years ago

Fixes #46

I took the liberty to fix the indentation in ChecksumController.php. Previously, tabs and spaces were mixed there.

As discussed in the linked issue, my changes will inevitably drop support for Owncloud. However, the usage of the modern Nextcloud API should make this app future proof for quite some time to come.

I strongly suggest to bump the version to 1.x.x after merging this PR.

cc @westberliner

st3iny commented 3 years ago

I'll checked the guidelines and if I am correct you are using tabs instead of spaces. Could you switch that?

@westberliner These guidelines state that one should use tabs for indentation (Quote: Use tabs to indent). But I'm fine with spaces too.

Thanks for your feedback. I implemented your suggestions and switched the indentation to spaces.

westberliner commented 3 years ago

@westberliner These guidelines state that one should use tabs for indentation (Quote: Use tabs to indent). But I'm fine with spaces too.

In the next line:

A tab is 4 spaces wide.

But I think I misunderstood it. Most of the nextcloud code is tabs. Sorry about that. I will check your changes later that day. Thx so far.

westberliner commented 3 years ago

Works :) Release is on the way.