westerlind / alfred-raindrop-search

Search or add Raindrop.io bookmarks from Alfred
MIT License
253 stars 14 forks source link

Fix opening escaped URL #16

Closed vitorgalvao closed 2 years ago

vitorgalvao commented 2 years ago

As reported on the forum, this needs a small fix for Alfred 5. Open URL is now more powerful and thus includes encoding options which are ticked by default and change the behaviour in this case.

This PR fixes that, but also collapses all Open URLs to a single one with a JSON config, which is easier to maintain. To add another browser, you’ll only have to edit the Conditional and nothing else:

image

Also bumped the version to 2.0.7 and changed the website to be this repo instead of Packal.

Packaged Workflow.

westerlind commented 2 years ago

Thanks @vitorgalvao

I'l have a look at this, and expect to release an updated version with this and some other fixes very soon.

vitorgalvao commented 2 years ago

I noticed you have Workflow Environment Variable which are only true or false. Those are the perfect use case for checkboxes in the new User Configuration. Do note the checkboxes set the variable as 0 or 1, not false or true. I didn’t touch that part since you’re using a compiled binary for that section.

westerlind commented 2 years ago

Does things like that break compatibility with Alfred 4, or is it simply ignored there?

vitorgalvao commented 2 years ago

It breaks compatibility, yes, as they’re different things. You’d remove the Workflow Environment Variables in favour of User Configuration. If it helps, Alfred 5 recognises the .alfred5workflow extension, while Alfred 4 does not. That’s a simple way to separate Workflows if you which to support multiple versions at once.

westerlind commented 2 years ago

I think I will try to keep compatibility with both 4 and 5 in one version (as far as that's possible) right now, and then release a version 3 later that could break compatibility with Alfred 4, and also adds some other larger changes I have been working on.

I have merged your changes (which does work well with Alfred 4 too), and will just fix a few other smaller things before releasing a new version.

Thanks!