Closed AmeyaVS closed 5 years ago
Thanks for the changes.
Merged.
Hi Ameya, Thank you again for your contribution to swerv-ISS. Recently, we have decided to change the license from GPL-3.0 to Apache-2.0 so that it matches our SweRV core licenses for consistency. Can you please confirm that we can use your contributions to swerve-ISS under Apache-2.0? Thanks, Joe Rahmeh
Hi Ameya,
Following up on my earlier email regarding Swerv-ISS. Please let me know if you are OK with your contributions been put under Apache-2.0 as we are looking to change the license to match that of our SweRV cores.
Thanks,
Joe Rahmeh
Hello @jrahmeh,
Regarding the contribution relicensing from GPL-3.0 to Apache-2.0, I have no objection.
Also, I would like to bring to your notice that the changes in the pull request #12 and #13. Were never ever properly attributed, even though the changes were manually integrated into the project.
Related Commits: here and here.
Regards, Ameya Vikram Singh
Ameya,
Thank you. I am not sure how to attribute the change. This is what I wrote on github (visible to all):
The new scope for label l11 in the decoder has been accepted and is now part of the code. Thank you. I would prefer not to change the GNUmakefile as that will affect local development. External user can always use "make BOOST_ROOT=x" where x is the path to their boost installation.
If there is anything else I can do to give you credit, I will be more than happy to do it.
Joe
On Wed, Mar 11, 2020 at 1:12 PM Ameya Vikram Singh notifications@github.com wrote:
Hello @jrahmeh https://github.com/jrahmeh,
Regarding the contribution relicensing from GPL-3.0 to Apache-2.0, I have no objection.
Also, I would like to bring to your notice that the changes in the pull request #12 https://github.com/westerndigitalcorporation/swerv-ISS/pull/12 and #13 https://github.com/westerndigitalcorporation/swerv-ISS/pull/13. Were never ever properly attributed, even though the changes were manually integrated into the project.
Related Commits: here https://github.com/AmeyaVS/swerv-ISS/commit/6d101e50a249d79ab9350c198e0644ae88beff32 and here https://github.com/AmeyaVS/swerv-ISS/commit/34ac03258359d83cc2b9aaab6db31bf719b3c08a .
Regards, Ameya Vikram Singh
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/westerndigitalcorporation/swerv-ISS/pull/11#issuecomment-597787941, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASHQX76AXQOWDMF7UMLADTRG7ICXANCNFSM4IMLLV7A .
#include
statments to include C++ Standard library headers instead ofC
style headers.isnan
function is available only instd
namespace, this fixes the compilation on multuple platforms.GNUmakefile
remove unusedboost_system
library dependency and cleanupSRCS_C
variable for removed source file.